[node-patches] Change in ovirt-node[master]: storage: Fix cross check between Host and AppVG

mburns at redhat.com mburns at redhat.com
Wed Oct 31 12:38:33 UTC 2012


Michael Burns has posted comments on this change.

Change subject: storage: Fix cross check between Host and AppVG
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

A couple things:
1.  storage_init=/dev/sda,/dev/sdb;/dev/sda
   ROOTDRIVE is on /dev/sda, but this isn't checked -- results in strange error since it puts AppVG on /dev/sda
2. This check probably shouldn't be in __init__. It results in an error on the screen like:
TypeError: __init__() should return None
instead of a message like
AppVG must be on a separate device and it currently overlaps with either Root or HostVG.

--
To view, visit http://gerrit.ovirt.org/8657
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9251637f175d582eac7b5a3c0161ab1bd81f0958
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list