[node-patches] Change in ovirt-node[master]: setup: Logging only configureable with network up

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: setup: Logging only configureable with network up
......................................................................

setup: Logging only configureable with network up

Previously the logging part of Node could be configured any time. This
lead to problems with netconsole, as netconsole is only working with an
avilable network interface.
This patch only allows the configuration of the logging components when
the network has been configured.

rhbz#843493

Change-Id: I23e5d01c238ec4c353e74e14b78c5d1a8bee0b0b
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/ovirt-config-setup.py
1 file changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/79/7979/1

diff --git a/scripts/ovirt-config-setup.py b/scripts/ovirt-config-setup.py
index c9e6e67..81ef137 100755
--- a/scripts/ovirt-config-setup.py
+++ b/scripts/ovirt-config-setup.py
@@ -833,7 +833,10 @@
 
     def logging_configuration_page(self, screen):
         elements = Grid(2, 8)
-        heading = Label("Logging")
+        if network_up():
+            heading = Label("Logging")
+        else:
+            heading = Label("Network Down, Logging Configuration Disabled")
         if is_console():
             heading.setColors(customColorset(1))
         elements.setField(heading, 0, 0, anchorLeft=1)
@@ -904,6 +907,12 @@
             self.netconsole_server_port.set("6666")
         else:
             self.netconsole_server_port.set(netconsole_server_port)
+
+        input_fields = [self.syslog_server, self.syslog_port,
+                        self.netconsole_server, self.netconsole_server_port]
+        if not network_up():
+            for field in input_fields:
+                field.setFlags(FLAG_DISABLED, FLAGS_SET)
         return [Label(""), elements]
 
     def authentication_configuration_page(self, screen):


--
To view, visit http://gerrit.ovirt.org/7979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23e5d01c238ec4c353e74e14b78c5d1a8bee0b0b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>