[node-patches] Change in ovirt-node[master]: tui: Enbale kdump location sonly if needed

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Sep 19 12:49:59 UTC 2012


Fabian Deutsch has uploaded a new change for review.

Change subject: tui: Enbale kdump location sonly if needed
......................................................................

tui: Enbale kdump location sonly if needed

Previosuly the entries for SSH and NFS locations were enabled even in
the case that the local storage was choosen.
Now the entries are only enabled when an SSH or NFS storage is choosen.

rhbz#852245

Change-Id: I137a8d7fd135d74c20d771615d7344a7b3320e85
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/ovirt-config-setup.py
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/56/8056/1

diff --git a/scripts/ovirt-config-setup.py b/scripts/ovirt-config-setup.py
index d6b38f3..e89d003 100755
--- a/scripts/ovirt-config-setup.py
+++ b/scripts/ovirt-config-setup.py
@@ -1413,15 +1413,15 @@
             kdump_config_file.close()
         except:
             pass
+        disable_fields = []
         if not network_up():
-            self.kdump_nfs_type.setFlags(_snack.FLAG_DISABLED,
-                                         _snack.FLAGS_SET)
-            self.kdump_ssh_type.setFlags(_snack.FLAG_DISABLED,
-                                         _snack.FLAGS_SET)
-            self.kdump_nfs_config.setFlags(_snack.FLAG_DISABLED,
-                                           _snack.FLAGS_SET)
-            self.kdump_ssh_config.setFlags(_snack.FLAG_DISABLED,
-                                           _snack.FLAGS_SET)
+            disable_fields += [self.kdump_nfs_type, self.kdump_ssh_type]
+        if not network_up() or (self.kdump_nfs_type.value() == 0 and \
+                                self.kdump_ssh_type.value() == 0):
+            disable_fields += [self.kdump_nfs_config, self.kdump_ssh_config]
+        for field in disable_fields:
+            field.setFlags(_snack.FLAG_DISABLED, _snack.FLAGS_SET)
+
         return [Label(""), elements]
 
     def support_page(self, screen):


--
To view, visit http://gerrit.ovirt.org/8056
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I137a8d7fd135d74c20d771615d7344a7b3320e85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list