[node-patches] Change in ovirt-node[master]: Only process kdump configuration changes when a type(nfs/ssh...

jboggs at redhat.com jboggs at redhat.com
Tue Sep 25 02:45:20 UTC 2012


Joey Boggs has uploaded a new change for review.

Change subject: Only process kdump configuration changes when a type(nfs/ssh/restore) is selected
......................................................................

Only process kdump configuration changes when a type(nfs/ssh/restore) is selected

rhbz#858196

Change-Id: Iea45121a4fec0ea0a56532d40504b59af631b95d
Signed-off-by: Joey Boggs <jboggs at redhat.com>
---
M scripts/ovirt-config-setup.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/79/8179/1

diff --git a/scripts/ovirt-config-setup.py b/scripts/ovirt-config-setup.py
index db88cd9..b53b351 100755
--- a/scripts/ovirt-config-setup.py
+++ b/scripts/ovirt-config-setup.py
@@ -1895,7 +1895,7 @@
     def process_kdump_config(self):
         if self.kdump_nfs_type.value() == 1:
             write_kdump_config(self.kdump_nfs_config.value())
-        if self.kdump_ssh_type.value() == 1:
+        elif self.kdump_ssh_type.value() == 1:
             write_kdump_config(self.kdump_ssh_config.value())
             self.screen.popWindow()
             self.screen.finish()
@@ -1910,8 +1910,10 @@
                 ovirt_store_config("/root/.ssh/kdump_id_rsa")
                 ovirt_store_config("/root/.ssh/known_hosts")
                 ovirt_store_config("/root/.ssh/config")
-        if self.kdump_restore_type.value() == 1:
+        elif self.kdump_restore_type.value() == 1:
             restore_kdump_config()
+        else:
+            return
         if not system("service kdump restart"):
             self._create_warn_screen()
             ButtonChoiceWindow(self.screen, "KDump Status",


--
To view, visit http://gerrit.ovirt.org/8179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea45121a4fec0ea0a56532d40504b59af631b95d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>



More information about the node-patches mailing list