[node-patches] Change in ovirt-node[master]: add ovirt-upgrade-tool to perform online upgrades with new c...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: add ovirt-upgrade-tool to perform online upgrades with new codebase
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File scripts/ovirt-upgrade-tool.py
Line 149:     if os.geteuid () != 0:
Line 150:         print >> sys.stderr, "You must run as root"
Line 151:         return 1
Line 152:     if select.select([sys.stdin,],[],[],0.0)[0]:
Line 153:         output = sys.stdin.read()
I wonder if this can be avoided because we are filling up ram with (potentially arbitary) data. Maybe this can be circumvented by redirecting stdout directly to the ISO file and printing out stdin.
Line 154:         stdout = sys.stdout
Line 155:         f = open('/data/ovirt-node-image.iso', 'w')
Line 156:         sys.stdout = f
Line 157:         print output


--
To view, visit http://gerrit.ovirt.org/13264
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I238b49b0a85d910d9db2c2b41e222afcce6b99c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>