[node-patches] Change in ovirt-node[master]: Add a diagnostic TUI page to view disk information

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Add a diagnostic TUI page to view disk information
......................................................................


Patch Set 10: I would prefer that you didn't submit this

(1 inline comment)

Basically this patch is fine. But is there a reason why you introduced a new widget? Maybe it makes more sense to just add the scrollbar to the existing Table widget.

....................................................
File scripts/tui/src/ovirt/node/ui/widgets.py
Line 287: 			                                                 3))
Line 288: 		    else:
Line 289:                         self.below_knob = abs(float(list_size - 
Line 290: 			                            rows) / (rows - 2 - 
Line 291: 						    self.ratio))
Please remove the trailing white-spaces and remove the trailing white-spaces.
Line 292:                 else:
Line 293:                     self.below_knob = float(list_size - rows)
Line 294:                 self.above_knob = int(offset / self.below_knob)
Line 295:                 (self._rows, self._list_size) = (rows, list_size)


--
To view, visit http://gerrit.ovirt.org/12339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6055bca2369398e2050561fa9388f3a4dfb8535
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>