[node-patches] Change in ovirt-node[master]: Add a diagnostic TUI page to view disk information

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Add a diagnostic TUI page to view disk information
......................................................................


Patch Set 11:

If it's easier, I can wrap TableWidget and make a child class which currently fulfills the purpose of the ScrollBox.  

That is: the ScrollBox doesn't depend on items defined as a list of tuples (this is easy enough to handle on a case-by-case basis with a TableWidget, if necessary), uses a different layout, and overrides render.

If you prefer, I can make it a child of TableWidget. Or add the scroll bar to TableWidget along with logic which determines whether or not the column for the knob should actually be shown.

--
To view, visit http://gerrit.ovirt.org/12339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6055bca2369398e2050561fa9388f3a4dfb8535
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>