[node-patches] Change in ovirt-node[master]: remove partition table during reinstall

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Apr 12 13:35:55 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: remove partition table during reinstall
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File dracut/ovirt-cleanup.sh
Line 151:         fi
Line 152:         info "Found and removing pv: $pv"
Line 153:         yes | lvm pvremove -ff "$pv"
Line 154:         # remove partition table
Line 155:         disk="$(echo "$pv"|sed 's ..$  ')"
This will lead to problems ... maybe we can get the device by some other way .. using pv or maybe lsblk?
Line 156:         info "Removing partition table for: $disk"
Line 157:         kpartx -d "$disk"
Line 158:         dd if=/dev/zero of="$disk" bs=1024k count=1
Line 159:     done


--
To view, visit http://gerrit.ovirt.org/13625
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfd6223edf79843b824603083041c64d9521dbd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list