[node-patches] Change in ovirt-node[master]: network: Fix NIC detection

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: network: Fix NIC detection
......................................................................

network: Fix NIC detection

The detection of system NICs includes the reload of the udev associated
data.
Previously the NIC name was passed to a udev command without quoting it,
this lead to problems when the NIC name included special characters
(e.g. the NIC name ";vdsmdummy;"). Now the NIC names are passed in
quotes to prevent problems when loading the udev data.

rhbz#924575

Change-Id: Iffaaacafa0db7115a4bba1dde9a5adcd2c084cfb
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/ovirtnode/network.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/14/13914/1

diff --git a/scripts/ovirtnode/network.py b/scripts/ovirtnode/network.py
index fc77085..f67a76c 100644
--- a/scripts/ovirtnode/network.py
+++ b/scripts/ovirtnode/network.py
@@ -435,7 +435,7 @@
 def get_system_nics():
     # Re-trigger udev for rhbz#866584
     for sysfspath in glob("/sys/class/net/*"):
-        _functions.system_closefds("udevadm test %s > /dev/null 2> /dev/null" % sysfspath)
+        _functions.system_closefds("udevadm test '%s' > /dev/null 2> /dev/null" % sysfspath)
 
     client = _functions.gudev.Client(['net'])
     configured_nics = 0


--
To view, visit http://gerrit.ovirt.org/13914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffaaacafa0db7115a4bba1dde9a5adcd2c084cfb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>