[node-patches] Change in ovirt-node[master]: Guard against evil chars in bridge names

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Apr 16 13:37:23 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: Guard against evil chars in bridge names
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File scripts/ovirtnode/network.py
Line 23: import tempfile
Line 24: import logging
Line 25: import os
Line 26: import subprocess
Line 27: from pipes import quote
Thanks!

I always looked for something like this (without knowing). A lib which can do the quoting.
Line 28: 
Line 29: logger = logging.getLogger(__name__)
Line 30: 
Line 31: 


--
To view, visit http://gerrit.ovirt.org/13872
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0caebe9a0423c6a04ba79bcaf5112ad267e8e377
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list