[node-patches] Change in ovirt-node[master]: build: Restructure check targets

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Apr 17 15:44:12 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: build: Restructure check targets
......................................................................

build: Restructure check targets

Change-Id: Ia1c4f8e53f73794934b3c28fb58debafa9d43b2a
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/Makefile.check
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/03/14003/1

diff --git a/src/Makefile.check b/src/Makefile.check
index d54e709..a5c53c2 100644
--- a/src/Makefile.check
+++ b/src/Makefile.check
@@ -4,43 +4,43 @@
 CLEANFILES=$(shell find . -name \*.pyc -o -name \*.pyo -o -name \*~ -o -name MANIFEST)
 
 
-check-local: syntax-checks doctests
+check-local: check-static check-doctests
 	@echo -e "---\n Passed all.\n---"
 
 
-syntax-checks: pep8 pyflakes
-	@echo -e "---\n Passed syntax checks.\n---"
+check-static: check-static-pep8 check-static-pyflakes
+	@echo -e "---\n Passed static checks.\n---"
 
-doctests:
+check-doctests:
 	@for M in $(PYTHONSOURCES); \
 	do \
 		echo Doctest on "$$M"; \
 		PYTHONPATH=. python -m doctest $$M || exit 1; \
 	done
 
-pep8:
+check-static-pep8:
 	@for M in $(PYTHONSOURCES); \
 	do \
 		echo pep8 on "$$M"; \
 		PYTHONPATH=. pep8 -r $$M || exit 1; \
 	done
 
-PYLINT=pylint -f parseable --include-ids=yes --rcfile=.pylintrc
-pylint:
+PYLINT=pylint --output-format=parseable --include-ids=yes --rcfile=.pylintrc
+check-static-pylint:
 	@for M in $(PYTHONSOURCES); \
 	do \
 		echo pylint on "$$M"; \
 		PYTHONPATH=. $(PYLINT) $$M || exit 1; \
 	done
 
-pyflakes:
+check-static-pyflakes:
 	@for M in $(PYTHONSOURCES); \
 	do \
 		echo pyflakes on "$$M"; \
 		PYTHONPATH=. pyflakes $$M || exit 1; \
 	done
 
-check-python26-compat:
+check-static-python26-compat:
 	@for M in $(PYTHONSOURCES); \
 	do \
 		echo Checking python26 syntax compatability on "$$M"; \


--
To view, visit http://gerrit.ovirt.org/14003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1c4f8e53f73794934b3c28fb58debafa9d43b2a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list