[node-patches] Change in ovirt-node[master]: net: Use ip instead of brctl

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: net: Use ip instead of brctl
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File scripts/ovirtnode/network.py
Line 408:             _functions.system_closefds("service network stop &> /dev/null")
Line 409:             _functions.system_closefds("service ntpd stop &> /dev/null")
Line 410:             # XXX eth assumed in breth
Line 411:             brctl_cmd = "ip --details --oneline link " \
Line 412:                 "| awk -F':' 'NR>1 && /^[0-9]: br[ep]/ {print $2}'"
NR>1 must be dropped (no header with ip)
Line 413:             brctl = _functions.subprocess_closefds(brctl_cmd, shell=True,
Line 414:                                                    stdout=subprocess.PIPE,
Line 415:                                         stderr=subprocess.STDOUT)
Line 416:             brctl_output = brctl.stdout.read()


--
To view, visit http://gerrit.ovirt.org/13635
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2022ce794ee2792e949457ad7664649c91702813
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>