[node-patches] Change in ovirt-node[master]: Stop crashing the plugin page by optimistically parsing file...

hadong0720 at gmail.com hadong0720 at gmail.com
Thu Aug 1 03:22:49 UTC 2013


hadong has posted comments on this change.

Change subject: Stop crashing the plugin page by optimistically parsing files
......................................................................


Patch Set 2:

Hey rbarry,

Found a small issue on your patch,after execute "p.read()", then if it execute "lines = p.readlines()" again, we will meet this issue: the content of "lines" will always be null.

-- 
To view, visit http://gerrit.ovirt.org/17549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf009e86b50e2a83d401f6a4dc6a2cb6c6a2e60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list