[node-patches] Change in ovirt-node[master]: Stop crashing the plugin page by optimistically parsing file...

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: Stop crashing the plugin page by optimistically parsing files
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirt/node/setup/core/plugins_page.py
Line 138:                             install_date = lines[2].strip().replace(
Line 139:                                 "Install Date:", "")
Line 140:                         else:
Line 141:                             try:
Line 142:                                 cmd = '/bin/rpm -qf %s/%s' % (plugin_dir, f)
add   --qf %{name}  on the end to only grab the name other wise you end up with

ovirt-node-plugin-vdsm-0.1.0-4.fc19.noarch(0.1.0-4.fc19.noarch) as the installed plugin name and less screen space due to the extra line on the console

otherwise ack
Line 143:                                 package = process.check_output(cmd.split(' ')
Line 144:                                                                ).strip()
Line 145:                                 cmd = "rpm -q %s --qf 'NAME: %s DATE: \
Line 146:                                        %%{version}-%%{release}.%%{arch} INST: \


-- 
To view, visit http://gerrit.ovirt.org/17549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf009e86b50e2a83d401f6a4dc6a2cb6c6a2e60
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server