[node-patches] Change in ovirt-node[master]: system: Fix which() always return None issue

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: system: Fix which() always return None issue
......................................................................


Patch Set 2: Verified-1 Code-Review-2

(1 comment)

....................................................
File src/ovirt/node/utils/system.py
Line 91:         The cmd with the absolute path if it was found in any path given in
Line 92:         $PATH. Otherwise None (if not found in any path in $PATHS).
Line 93:     """
Line 94:     ret = None
Line 95:     if os.path.abspath(cmd) and File(cmd).exists():
The problem, is not fixed. isabs needs to be used instead of abspath.
Line 96:         ret = cmd
Line 97:     else:
Line 98:         for dirname in os.environ["PATH"].split(":"):
Line 99:             fn = os.path.join(dirname, cmd)


-- 
To view, visit http://gerrit.ovirt.org/17600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic054a5e48214e9f39994c962863030681c4b3622
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes