[node-patches] Change in ovirt-node[master]: Show a confirmation dialog if the network is already configured

rbarry at redhat.com rbarry at redhat.com
Wed Aug 7 22:39:09 UTC 2013


Ryan Barry has uploaded a new change for review.

Change subject: Show a confirmation dialog if the network is already configured
......................................................................

Show a confirmation dialog if the network is already configured

With the move to the new TUI, we lost the confirmation dialog when
entering network configuration with an interface already
configured. Add it back.

Change-Id: I2c41fa8f299d2670aa9d0d60646a49c00e25ec6d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=981188
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/96/17796/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index 3c790a6..ea41516 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -256,6 +256,15 @@
             self.logger.debug("Opening NIC Details dialog for '%s'" % iface)
             self._model_extra["dialog.nic.ifname"] = iface
             self._nic_dialog = NicDetailsDialog(self, iface)
+
+            if network.NodeNetwork().is_configured():
+                txt = "Network Configuration detected an already configured NIC. The configuration for that NIC is "
+                txt += "going to be removed if changes are made. Proceed?"
+                self._confirm_dialog = ui.ConfirmationDialog("dialog.confirm", "Confirm Network Settings", txt)
+                return self._confirm_dialog
+
+        if "dialog.confirm.yes" in changes:
+            self._confirm_dialog.close()
             return self._nic_dialog
 
         if "dialog.nic.close" in changes:


-- 
To view, visit http://gerrit.ovirt.org/17796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c41fa8f299d2670aa9d0d60646a49c00e25ec6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list