[node-patches] Change in ovirt-node[master]: fix previous commit

rbarry at redhat.com rbarry at redhat.com
Thu Aug 8 14:06:16 UTC 2013


Ryan Barry has posted comments on this change.

Change subject: fix previous commit
......................................................................


Patch Set 2: Code-Review-1

This was intended to cover the case of plugins which do not properly install metadata files which can be parsed by the plugin page because they were not installed with edit-node. 

You can verify that the VDSM-enabled images (where VDSM is added without edit-node but leaves files in /etc/ovirt-plugins.d) crash the plugin page or do not display information about the installed plugin without lines 142-145. They are not superfluous.

-- 
To view, visit http://gerrit.ovirt.org/17804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1648b1e8d446476d47ac09daf86645d0687ac783
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No



More information about the node-patches mailing list