[node-patches] Change in ovirt-node[master]: network: Don't remove bonding module on cleanup

[asegurap at redhat.com]

Antoni Segura Puimedon has posted comments on this change.

Change subject: network: Don't remove bonding module on cleanup
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Small typo

....................................................
File src/ovirt/node/utils/network.py
Line 834:     def delete(self, mifname):
Line 835:         """Delete a bond master
Line 836:         """
Line 837:         if not self.is_bond(mifname):
Line 838:             raise RuntimeError("Can no delete '%s', is no bond" % mifname)
There is a typo, it should be "Cannot delete '%s', it is not a bond"
Line 839:         #process.call(["ip", "link", "set", "dev", mifname, "down"])
Line 840:         #process.call(["ip", "link", "delete", mifname, "type", "bond"])


-- 
To view, visit http://gerrit.ovirt.org/17832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2eada10beeb981ecf6b4dbe1b51d2c38f8daea7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes