[node-patches] Change in ovirt-node[master]: network: Networking is also needed with bonds

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Aug 8 18:36:49 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: network: Networking is also needed with bonds
......................................................................

network: Networking is also needed with bonds

Previously global networking was only enabled when a device got
configured, but networking is also required when a bond device is
created. Otherwise the bond device will not turn up in the system and
the UI.

Change-Id: I18d8eb775b08cf93e0024d597a4aa3c1044b4e89
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/config/defaults.py
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/50/17850/1

diff --git a/src/ovirt/node/config/defaults.py b/src/ovirt/node/config/defaults.py
index eef9e9c..d416fbb 100644
--- a/src/ovirt/node/config/defaults.py
+++ b/src/ovirt/node/config/defaults.py
@@ -317,18 +317,22 @@
                 m = Network().retrieve()
                 aug = AugeasWrapper()
 
+                needs_networking = False
+
                 bond = NicBonding().retrieve()
                 if bond["slaves"]:
                     NicBonding().transaction().commit()
+                    needs_networking = True
 
-                has_network = m["iface"] is not None
-                if has_network:
+                if m["iface"]:
                     self.__write_config()
+                    needs_networking = True
 
                 self.__write_lo()
 
                 aug.set("/files/etc/sysconfig/network/NETWORKING",
-                        "yes" if has_network else "no")
+                        "yes" if needs_networking else "no")
+
                 fs.Config().persist("/etc/sysconfig/network")
                 fs.Config().persist("/etc/hosts")
 


-- 
To view, visit http://gerrit.ovirt.org/17850
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18d8eb775b08cf93e0024d597a4aa3c1044b4e89
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list