[node-patches] Change in ovirt-node[master]: Show a confirmation dialog if the network is already configured

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Show a confirmation dialog if the network is already configured
......................................................................


Patch Set 5:

(2 comments)

....................................................
File src/ovirt/node/setup/core/network_page.py
Line 264:                            ui.CloseButton("dialog.confirm.close",
Line 265:                                           label="Cancel")]
Line 266:                 self._confirm_dialog = ui.ConfirmationDialog("dialog.confirm",
Line 267:                                                              "Confirm Network \
Line 268:                                                               Settings", txt,
Won't "Settings" have many leading white-spaces?
Line 269:                                                              buttons)
Line 270:                 return self._confirm_dialog
Line 271: 
Line 272:         if "dialog.confirm.yes" in changes:


Line 265:                                           label="Cancel")]
Line 266:                 self._confirm_dialog = ui.ConfirmationDialog("dialog.confirm",
Line 267:                                                              "Confirm Network \
Line 268:                                                               Settings", txt,
Line 269:                                                              buttons)
I just wonder if we should adjust the labels of the buttons of the ConfirmationDialog to be more specific, e.g. Yes/No or OK/Cancel.
Just for the reason of less code duplication
Line 270:                 return self._confirm_dialog
Line 271: 
Line 272:         if "dialog.confirm.yes" in changes:
Line 273:             self._confirm_dialog.close()


-- 
To view, visit http://gerrit.ovirt.org/17796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c41fa8f299d2670aa9d0d60646a49c00e25ec6d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes