[node-patches] Change in ovirt-node[master]: puppet: Persist puppet.conf when it get's changed

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: puppet: Persist puppet.conf when it get's changed
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/setup/puppet/puppet_page.py
Line 152:                 else:
Line 153:                     conf.write("\n" + line, "a")
Line 154:             except:
Line 155:                 conf.write("\n" + line, "a")
Line 156:         from ovirtnode.ovirtfunctions import ovirt_store_config
please use fs.Config().persist(filename) instead
Line 157:         ovirt_store_config("/etc/puppet/puppet.conf")
Line 158: 
Line 159:         system.service("puppet", "stop")
Line 160:         utils.process.check_call("puppet agent --test", shell=True)


-- 
To view, visit http://gerrit.ovirt.org/17529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieacb4030d0fe4100fb002f5b1db62358d1d75012
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes