[node-patches] Change in ovirt-node[master]: Fix clear /etc/puppet/puppet.conf issue

hadong0720 at gmail.com hadong0720 at gmail.com
Fri Aug 9 10:47:15 UTC 2013


hadong has posted comments on this change.

Change subject: Fix clear /etc/puppet/puppet.conf issue
......................................................................


Patch Set 3:

Hey Fabian,
Accept you second comments suggestion, for the first comments,
we shouldn't do that, we need set "lines = File("/etc/puppet/puppet.conf").read().split("\n")" before exectue "conf.write("")" to clear the file "/etc/puppet/puppet.conf"

thanks,
hadong

-- 
To view, visit http://gerrit.ovirt.org/17522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idffce430477f9d44d2a8bff12ad518b479e86648
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No



More information about the node-patches mailing list