[node-patches] Change in ovirt-node[master]: init: Add support for logrotate_max_size cmdline args

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Aug 9 11:50:49 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for logrotate_max_size cmdline args
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

....................................................
File src/ovirtnode/log.py
Line 201: 
Line 202: 
Line 203: def logrotate_auto():
Line 204:     logroate_max_size = ""
Line 205:     if not "OVIRT_LOGROTATE_MAX_SIZE" in _functions.OVIRT_VARS:
you can completely remove this branch
Line 206:         return False
Line 207:     else:
Line 208:         logroate_max_size = _functions.OVIRT_VARS["OVIRT_LOGROTATE_MAX_SIZE"]
Line 209:         if not logroate_max_size is "":


-- 
To view, visit http://gerrit.ovirt.org/17707
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5aaea8e16390415db69458937d4bb495c9734d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list