[node-patches] Change in ovirt-node[master]: Show a dialog before entering the rescue console

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Show a dialog before entering the rescue console
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

....................................................
File src/ovirt/node/app.py
Line 400:             txt += "use this without guidance from support representatives"
Line 401:             dialog = ui.ConfirmationDialog("dialog.shell", "Rescue Shell", txt
Line 402:                                            )
Line 403: 
Line 404:             dialog.buttons[0].on_activate.connect(return_ok)
For this patch it's fine, but maybe we should introduce two signals in the ConfirmationDialog to connect to yes/no ok/cancel
Line 405:             dialog.buttons[0].on_activate.connect(ui.CloseAction())
Line 406:             self.show(dialog)
Line 407: 
Line 408:         except:


-- 
To view, visit http://gerrit.ovirt.org/17795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37bd24c89ba8f4272435aa846f658a0a06d5aa08
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes