[node-patches] Change in ovirt-node[master]: Add parameters and code to back kdump autoinstall parameters

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Add parameters and code to back kdump autoinstall parameters
......................................................................


Patch Set 1: Code-Review-1

Basically the patch is fine, just two things:

1. It's not obvious what value the new args take e.g. the *_ssh_key arg takes an url, from the name I'd guess that it takes the sshkey itself.

2. I wonder if the fetching+ssh-into parts should go higher up into the defaults.Kdump class - os that it could be reused later on. At least the ssh-into is a good candidate for it.

-- 
To view, visit http://gerrit.ovirt.org/17894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide8d438aa19f0189a4d3d37399ffd57cd8774584
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No