[node-patches] Change in ovirt-node[master]: Fix clear /etc/puppet/puppet.conf issue.

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix clear /etc/puppet/puppet.conf issue.
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/setup/puppet/puppet_page.py
Line 145:         conf_builder = ""
Line 146:         for line in conf:
Line 147:             try:
Line 148:                 item = re.match(r'^\s+(\w+) =', line).group(1)
Line 149:                 if item in cfg:
This doesn't make sense.
In line 148 you assign the re.group() value to `item`
And in line 149 you use the variable item to iterate to the cfg keys.

I suppose you want to use two different var names here or do I understand it wrong? Maybe oyu could explain what you want to achieve.
Line 150:                     conf_builder += re.sub(r'(^.*?' + item + ' =).*',
Line 151:                                            r'\1 "' + cfg[item] + '"',
Line 152:                                            line)
Line 153:                 else:


-- 
To view, visit http://gerrit.ovirt.org/17522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idffce430477f9d44d2a8bff12ad518b479e86648
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes