Fabian Deutsch has posted comments on this change.
Change subject: Fix [Error 2]No such file or directory issue when setting NFSv4 Domain.
......................................................................
Patch Set 5:
(2 comments)
Sorry, didn't see my last nitpick the last time. Otherwise it's good!
....................................................
File src/ovirt/node/utils/storage.py
Line 54: if current_domain.startswith("#"):
Line 55: current_domain = ("#Domain = %s" %
Line 56: current_domain.replace("# ", ""))
Line 57: cmd = ['sed', '-i', '-c', 's/%s/Domain = %s/g' %
Line 58: (current_domain, domain), '%s' %
You can use the self.configfilename directly.
Line 59: self.configfilename]
Line 60: else:
Line 61: cmd = ['sed', '-i', '-c', '/^Domain/ s/%s/%s/g' %
Line 62: (current_domain, domain), '%s' %
Line 59: self.configfilename]
Line 60: else:
Line 61: cmd = ['sed', '-i', '-c', '/^Domain/ s/%s/%s/g' %
Line 62: (current_domain, domain), '%s' %
Line 63: self.configfilename]
Same as above: You can use the self.configfilename directly.
Line 64: process.check_call(cmd)
Line 65:
Line 66: def __get_domain(self):
Line 67: domain = None
--
To view, visit http://gerrit.ovirt.org/18278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dded758e8dc6a61c3af1ec4445ff276c61fa5eb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes