[node-patches] Change in ovirt-node[master]: Disable the TUI in rescue mode

jboggs at redhat.com jboggs at redhat.com
Fri Aug 23 17:09:36 UTC 2013


Joey Boggs has posted comments on this change.

Change subject: Disable the TUI in rescue mode
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/utils/system.py
Line 71:     """If the system is running in rescue mode
Line 72:     """
Line 73:     return "rescue" in open("/proc/cmdline").read().split()
Line 74: 
Line 75: 
you'll need to also check the runlevel for 1 or S as well, from ovirtfunctions.py

def is_rescue_mode():
    ret = system_closefds("grep -q rescue /proc/cmdline")
    if ret == 0:
        return True
    # check for runlevel 1/single
    else:
        ret = system_closefds("runlevel|grep -q '1\|S'")
        if ret == 0:
            return True
        return False
Line 76: def cpu_details():
Line 77:     """Return details for the CPU of this machine, virt related
Line 78:     """
Line 79:     from ovirtnode.ovirtfunctions import cpu_details


-- 
To view, visit http://gerrit.ovirt.org/18193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f9d6fbd944cd9c86b7ae85e031477d7184f868
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list