[node-patches] Change in ovirt-node[master]: init: Add support for nfsv4_domain cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for nfsv4_domain cmdline args
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

....................................................
File scripts/ovirt-auto-install.py
Line 110: 
Line 111:     def commit(self):
Line 112:         if "OVIRT_NFSV4_DOMAIN" in OVIRT_VARS and \
Line 113:            not OVIRT_VARS["OVIRT_NFSV4_DOMAIN"] is "":
Line 114:             nfsv4 = storage.NFSv4()
NFSv4 is configured using the config.defaults.NFSv4() class.

The difference between the two is:
utils.storage.NFSv4() only updates the nfs config files
config.defaults.NFSv4() also updates /detc/default/ovirt  -this is important so the UI shows the correct informations - also this class persists the correct files, so you don't need to take care about that.
Line 115:             nfsv4.domain(OVIRT_VARS["OVIRT_NFSV4_DOMAIN"])
Line 116:             ovirt_store_config(nfsv4.configfilename)
Line 117:             system_closefds("service rpcidmapd restart &> /dev/null")
Line 118:             system_closefds("nfsidmap -c &> /dev/null")


-- 
To view, visit http://gerrit.ovirt.org/18463
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12a3236b421128ad6effbb4793fa5280c6d71b1c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes