[node-patches] Change in ovirt-node[master]: init: Add support for logrotate_max_size cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for logrotate_max_size cmdline args
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

....................................................
File src/ovirtnode/log.py
Line 113:         logger.info("Netconsole Configuration Updated")
Line 114:     return True
Line 115: 
Line 116: 
Line 117: def set_logrotate_size(size):
Please use config.defaults.Logrotate().
That class will also update etc/default/ovirt and will also persist the necessary files.

Avoids code duplication.
Line 118:     try:
Line 119:         _functions.augtool("set", \
Line 120:                            "/files/etc/logrotate.d/ovirt-node/rule/size", size)
Line 121:         _functions.ovirt_store_config("/etc/logrotate.d/ovirt-node")


-- 
To view, visit http://gerrit.ovirt.org/17707
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5aaea8e16390415db69458937d4bb495c9734d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes