[node-patches] Change in ovirt-node[master]: init: Add support for use_strong_rng cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for use_strong_rng cmdline args
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File scripts/ovirt-auto-install.py
Line 76:     title = "Configuring SSH strong RNG"
Line 77: 
Line 78:     def commit(self):
Line 79:         if "OVIRT_USE_STRONG_RNG" in OVIRT_VARS and \
Line 80:            not OVIRT_VARS["OVIRT_USE_STRONG_RNG"] is "":
Please use a class from config.defaults here.
And maybe you can pull all if-then the logic into line 154
Line 81:             ssh = security.Ssh()
Line 82:             ssh.strong_rng(OVIRT_VARS["OVIRT_USE_STRONG_RNG"])
Line 83: 
Line 84: 


-- 
To view, visit http://gerrit.ovirt.org/18457
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2f4c4d9f9daf59b6fd95fe0d641260394ecab5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes