[node-patches] Change in ovirt-node[master]: init: Add support for keyboard layout cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for keyboard layout cmdline args
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

....................................................
File scripts/ovirt-auto-install.py
Line 77:     title = "Setting Keyboard Layout"
Line 78: 
Line 79:     def commit(self):
Line 80:         if "OVIRT_KEYBOARD_LAYOUT" in OVIRT_VARS and \
Line 81:            not OVIRT_VARS["OVIRT_KEYBOARD_LAYOUT"] is "":
Maybe you can pull all if-then the logic into line 157
Line 82:             model = defaults.Keyboard()
Line 83:             model.update(layout=OVIRT_VARS["OVIRT_KEYBOARD_LAYOUT"])
Line 84:             tx = model.transaction()
Line 85:             tx()


-- 
To view, visit http://gerrit.ovirt.org/18455
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f0f972c4b2cef433269567f25646869d010d30b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes