[node-patches] Change in ovirt-node[master]: init: Add support for disable_aes_ni cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for disable_aes_ni cmdline args
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

....................................................
File scripts/ovirt-auto-install.py
Line 100:     title = "Configuring SSH AES NI"
Line 101: 
Line 102:     def commit(self):
Line 103:         if "OVIRT_DISABLE_AES_NI" in OVIRT_VARS and \
Line 104:            OVIRT_VARS["OVIRT_DISABLE_AES_NI"] == "true":
you can use ovirt-node.utils.parse_bool() here - to also accept 1,yes,True and true
Line 105:             model = defaults.SSH()
Line 106:             model.update(disable_aesni=True)
Line 107:             tx = model.transaction()
Line 108:             tx()


....................................................
File scripts/ovirt-init-functions.sh.in
Line 732:             tuned*)
Line 733:             tuned_profile=${i#tuned=}
Line 734:             ;;
Line 735:             disable_aes_ni=1 | disable_aes_ni=y | disable_aes_ni=yes)
Line 736:             disable_aes_ni="true"
Please use consistently either True/False or true/false - not true/False
Line 737:             ;;
Line 738:             disable_aes_ni=0 | disable_aes_ni=n | disable_aes_ni=no)
Line 739:             disable_aes_ni="False"
Line 740:             ;;


-- 
To view, visit http://gerrit.ovirt.org/18459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665c0ebfbc5cd16cffa307cd9ac4d99ec38761ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes