[node-patches] Change in ovirt-node[master]: Get serial console working on Fedora and add TUI configuration

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Get serial console working on Fedora and add TUI configuration
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/setup/core/status_page.py
Line 258:         self.plugin.model()
Line 259:         self.children = [ui.Entry("console.path", "Console path:")]
Line 260: 
Line 261:     def __find_grub_cfg(self):
Line 262:         from ovirtnode import ovirtfunctions
I actually want to avoid importting ovirtfunctions in the new codebase - except in the ovirt.node.utils package.

Please add a module e.g. bootlader.py or add this function to system.py
Line 263:         import os
Line 264: 
Line 265:         cfg_path = ""
Line 266: 


-- 
To view, visit http://gerrit.ovirt.org/17982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id99623830b56b77815196c8b0d153c86d3704f00
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes