[node-patches] Change in ovirt-node[master]: Don't show putout from ipmitool check status

rbarry at redhat.com rbarry at redhat.com
Mon Dec 2 18:43:56 UTC 2013


Ryan Barry has uploaded a new change for review.

Change subject: Don't show putout from ipmitool check status
......................................................................

Don't show putout from ipmitool check status

Previously, output from the IPMI plugin was spuriously shown,
which gave the appearance of hanging if enter was pressed. Rather
than dumping it to /dev/null, just catch it instead.

Change-Id: I776fc9b56ed797e80f48cafb770e976258786884
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026646
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/ipmi/ipmi_page.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/29/21929/1

diff --git a/src/ovirt/node/setup/ipmi/ipmi_page.py b/src/ovirt/node/setup/ipmi/ipmi_page.py
index 10b9616..96d99dd 100644
--- a/src/ovirt/node/setup/ipmi/ipmi_page.py
+++ b/src/ovirt/node/setup/ipmi/ipmi_page.py
@@ -83,7 +83,7 @@
 
     def check_status(self):
         try:
-            process.check_call(["ipmitool", "-I", "open", "chassis", "status"])
+            process.check_output(["ipmitool", "-I", "open", "chassis", "status"])
             return True
         except CalledProcessError:
             return False


-- 
To view, visit http://gerrit.ovirt.org/21929
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I776fc9b56ed797e80f48cafb770e976258786884
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list