[node-patches] Change in ovirt-node[master]: Make sure plugin autoinstall files stay in their packages

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Make sure plugin autoinstall files stay in their packages
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

....................................................
File ovirt-node.spec.in
Line 578: %config(noreplace) %{_sysconfdir}/cron.d/ovirt-logrotate
Line 579: 
Line 580: %{mgmt_scripts_dir}
Line 581: %{_sysconfdir}/ovirt-config-boot.d
Line 582: %exclude %{_sysconfdir}/ovirt-config-boot.d/*_autoinstall.py*
What we can use here is

    %dir %{_sysconfdir}/ovirt-config-boot.d/

This will own the dir, but not it's contents.
Is there any autoinstall fiel we should ship in the main package?
Line 583: 
Line 584: %if %{is_f16}
Line 585: %{_unitdir}/libvirtd.service
Line 586: %endif


Line 629: %{python_sitelib}/ovirtnode
Line 630: %{python_sitelib}/augeas*
Line 631: %{_sysconfdir}/ovirt-early.d
Line 632: %{_sysconfdir}/ovirt-commandline.d
Line 633: %exclude %{_sysconfdir}/ovirt-commandline.d/*
Same as a above

    %dir %{_sysconfdir}/ovirt-commandline.d/

to own the dir, but not the contents, except when they should be part of the main package
Line 634: %if %{is_systemd}
Line 635: %{_unitdir}/ovirt.service
Line 636: %{_unitdir}/ovirt-awake.service
Line 637: %{_unitdir}/ovirt-firstboot.service


-- 
To view, visit http://gerrit.ovirt.org/22093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I036b8b37dd63b1b6126cfe2af72f2ef3f6a3afc8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-HasComments: Yes