[node-patches] Change in ovirt-node[master]: check: Small fixups

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Dec 6 14:18:58 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: check: Small fixups
......................................................................

check: Small fixups

Change-Id: I152e761d2a1c56acdc5b394501479471629a49de
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/core/kdump_page.py
M src/ovirt/node/utils/system.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/27/22127/1

diff --git a/src/ovirt/node/setup/core/kdump_page.py b/src/ovirt/node/setup/core/kdump_page.py
index 58a4038..98bf7e3 100644
--- a/src/ovirt/node/setup/core/kdump_page.py
+++ b/src/ovirt/node/setup/core/kdump_page.py
@@ -194,14 +194,14 @@
         except Exception as e:
             # Restore the configuration
             if saved_model["kdump.type"] == "nfs":
-                model.update(saved_model["kdump.nfs_location"], None, None, 
+                model.update(saved_model["kdump.nfs_location"], None, None,
                              None)
             elif saved_model["kdump.type"] == "kdump.ssh_location":
                 if self.model()["kdump.ssh_key"] is not "":
-                    model.update(None, saved_model['kdump.ssh_location'], 
+                    model.update(None, saved_model['kdump.ssh_location'],
                                  saved_model['kdump.ssh_key'], None)
                 else:
-                    model.update(None, saved_model['kdump.ssh_location'], 
+                    model.update(None, saved_model['kdump.ssh_location'],
                                  None, None)
             elif saved_model["kdump.type"] == "local":
                 model.update(None, None, None, True)
diff --git a/src/ovirt/node/utils/system.py b/src/ovirt/node/utils/system.py
index d8dc35d..f4387df 100644
--- a/src/ovirt/node/utils/system.py
+++ b/src/ovirt/node/utils/system.py
@@ -120,7 +120,7 @@
         r = process.check_output(["service", name, cmd], **kwargs)
     except process.CalledProcessError as e:
         r = e.returncode
-        LOGGER.debug("Service cmd failed: %s %s" % (name,cmd), exc_info=True)
+        LOGGER.exception("Service cmd failed: %s %s" % (name, cmd))
         LOGGER.debug("Service output: %s" % e.output)
         if do_raise:
             raise


-- 
To view, visit http://gerrit.ovirt.org/22127
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I152e761d2a1c56acdc5b394501479471629a49de
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list