[node-patches] Change in ovirt-node[master]: Clear the storage volume page when free space is positive

rbarry at redhat.com rbarry at redhat.com
Wed Dec 11 17:23:51 UTC 2013


Ryan Barry has uploaded a new change for review.

Change subject: Clear the storage volume page when free space is positive
......................................................................

Clear the storage volume page when free space is positive

It was possible to get into a state where the storage volume page
was still flagged as invalid, even when all sizes were fine. Now,
we should retrigger validation of every invalid field when free
space is not negative, so it behaves as expected.

Change-Id: Iad090893533a2152f8419e234c287f2024594f1a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022475
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/installer/core/storage_vol_page.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/07/22307/1

diff --git a/src/ovirt/node/installer/core/storage_vol_page.py b/src/ovirt/node/installer/core/storage_vol_page.py
index 06d887b..d5d8451 100644
--- a/src/ovirt/node/installer/core/storage_vol_page.py
+++ b/src/ovirt/node/installer/core/storage_vol_page.py
@@ -122,6 +122,11 @@
                     raise InvalidData("Data partition must be at least 0 MB")
                 else:
                     raise InvalidData("Free space must not be negative")
+            else:
+                for w in self.widgets:
+                    if hasattr(self.widgets[w], "notice"):
+                        self.widgets[w].notice("")
+                self._on_ui_change(self._NodePLugin__invalid_changes)
 
     def on_merge(self, effective_changes):
         changes = self.pending_changes(False)


-- 
To view, visit http://gerrit.ovirt.org/22307
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad090893533a2152f8419e234c287f2024594f1a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list