[node-patches] Change in ovirt-node[master]: move iptables rules to firewalld service rhbz#894061

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: move iptables rules to firewalld service rhbz#894061
......................................................................


Patch Set 1: (2 inline comments)

Looks good. Just two tiny things

....................................................
Commit Message
Line 3: AuthorDate: 2013-02-05 13:43:13 -0500
Line 4: Commit:     Joey Boggs <jboggs at redhat.com>
Line 5: CommitDate: 2013-02-05 13:49:29 -0500
Line 6: 
Line 7: move iptables rules to firewalld service rhbz#894061
rhbz# should be in it's own line
Line 8: 
Line 9: Change-Id: Id23b9e83e3822066345594a03d693a59a27e7af5


....................................................
File recipe/ovirt17-post.ks
Line 33: cat > /usr/lib/firewalld/services/ovirt.xml << \EOF
Line 34: <?xml version="1.0" encoding="utf-8"?>
Line 35: <service>
Line 36:   <short>ovirt-node</short>
Line 37:   <description>This option allo.</description>
Maybe you could add a real description - yes it's just something really minor :)
Line 38:   <!-- vdsm -->
Line 39:   <port protocol="tcp" port="54321"/>
Line 40:   <!-- libvirt tls -->
Line 41:   <port protocol="tcp" port="16514"/>


--
To view, visit http://gerrit.ovirt.org/11760
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id23b9e83e3822066345594a03d693a59a27e7af5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>