[node-patches] Change in ovirt-node[master]: [DRAFT] ui: Add function to catch InvalidData exceptions

mburns at redhat.com mburns at redhat.com
Tue Feb 12 22:02:40 UTC 2013


Michael Burns has posted comments on this change.

Change subject: [DRAFT] ui: Add function to catch InvalidData exceptions
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

just adding a comment that I already shared on irc:

this catches intermediate errors that shouldn't be caught.

for example, typing "engine.example.com" into the ovirt-engine page will result in it catching warnings for an invalid hostname twice while typing:

engine.
engine.example.

These are caught on screen, but shouldn't trigger a new warning screen

--
To view, visit http://gerrit.ovirt.org/11990
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61be3627dcdf1cba957811fc39485410e3bc94f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list