[node-patches] Change in ovirt-node[master]: fix labels and ordering for kdump config page

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Feb 13 14:31:53 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: fix labels and ordering for kdump config page
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File scripts/tui/src/ovirt/node/setup/kdump_page.py
Line 82:                        "(example.redhat.com:/var/crash):",
Line 83:                        align_vertical=True),
Line 84:               ui.Divider("divider[0]"),
Line 85:               ui.Entry("kdump.ssh_location", "SSH Location " +
Line 86:                        "root at example.redhat.com):",
Maybe you could also add the missing leading ( (opening bracket)
Line 87:                        align_vertical=True),
Line 88:               ]
Line 89:         page = ui.Page("page", ws)
Line 90:         self.widgets.add(page)


--
To view, visit http://gerrit.ovirt.org/12024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c82fbbe95c481a2110872e25141e30905ed0ed4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list