[node-patches] Change in ovirt-node[master]: Job control in emergency shell - BZ753315

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Feb 13 15:48:18 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: Job control in emergency shell - BZ753315
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Looks good to me, just a note on the commit msg

....................................................
Commit Message
Line 7: Job control in emergency shell - BZ753315
Line 8: 
Line 9: Signed-off-by: Ryan Barry <rbarry at redhat.com>
Line 10: 
Line 11: Job control not working due to bash subprocess.  Replace bash call with openvt
I'd suggest to have the commit message along the following schema:

---
short-summary

description

rhbz#XXXX

Signed-off-by: XXX
---
Line 12: 
Line 13: Change-Id: Idcb0ef9053d43b26645c6e4c6dcc6108a1e7916c


--
To view, visit http://gerrit.ovirt.org/12029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb0ef9053d43b26645c6e4c6dcc6108a1e7916c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list