[node-patches] Change in ovirt-node[master]: --- Job control in emergency shell

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: --- Job control in emergency shell
......................................................................


Patch Set 3: (4 inline comments)

Testing still pending, but some commit message comments...

I'll upload a cleaned up example shortly.

....................................................
Commit Message
Line 3: AuthorDate: 2013-02-13 08:23:54 -0700
Line 4: Commit:     Ryan Barry <rbarry at redhat.com>
Line 5: CommitDate: 2013-02-14 06:02:56 -0700
Line 6: 
Line 7: --- Job control in emergency shell
no need for ---
Line 8: 
Line 9: Job control was not working in the rescue shell.  Replace the call to bash with openvt, which fulfills all of bash's internal requirements to enable job control.
Line 10: 
Line 11: rhbz753315


Line 5: CommitDate: 2013-02-14 06:02:56 -0700
Line 6: 
Line 7: --- Job control in emergency shell
Line 8: 
Line 9: Job control was not working in the rescue shell.  Replace the call to bash with openvt, which fulfills all of bash's internal requirements to enable job control.
best practice is keep these lines manually formatted to ~67 chars at most.  A good guideline is the first commented line when you run git commit.  Keep it at that length or shorter and you're good
Line 10: 
Line 11: rhbz753315
Line 12: 
Line 13: Signed-off-by: Ryan Barry <rbarry at redhat.com>


Line 7: --- Job control in emergency shell
Line 8: 
Line 9: Job control was not working in the rescue shell.  Replace the call to bash with openvt, which fulfills all of bash's internal requirements to enable job control.
Line 10: 
Line 11: rhbz753315
glad to see this, just one nitpick -- you forgot the #

rhbz#753315
Line 12: 
Line 13: Signed-off-by: Ryan Barry <rbarry at redhat.com>
Line 14: 
Line 15: Change-Id: Idcb0ef9053d43b26645c6e4c6dcc6108a1e7916c


Line 9: Job control was not working in the rescue shell.  Replace the call to bash with openvt, which fulfills all of bash's internal requirements to enable job control.
Line 10: 
Line 11: rhbz753315
Line 12: 
Line 13: Signed-off-by: Ryan Barry <rbarry at redhat.com>
Fabian mentioned this, but I'll mention it again.  You only need this line once.  

Simply run git commit with the -s flag and it will add it at the end.  Then, as long as you leave an empty line before it, it should format correctly.  

If you forget, "git commit --amend -s" should fix it.
Line 14: 
Line 15: Change-Id: Idcb0ef9053d43b26645c6e4c6dcc6108a1e7916c


--
To view, visit http://gerrit.ovirt.org/12029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb0ef9053d43b26645c6e4c6dcc6108a1e7916c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>