[node-patches] Change in ovirt-node[master]: fix edit-node options check for plugins

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Feb 22 12:19:12 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: fix edit-node options check for plugins
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tools/edit-node
Line 1496:                 edited_iso = os.path.join(output, editor.name + ".iso")
Line 1497:                 if options.install_dup:
Line 1498:                     n = options.install_dup
Line 1499:                 elif options.plugin:
Line 1500:                     n = options.install_plugin
Doesn't it need to be .plugin here as well?
Line 1501:                 elif options.install:
Line 1502:                     n = options.install
Line 1503:                 else:
Line 1504:                     n = ""


--
To view, visit http://gerrit.ovirt.org/12305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a27b9e63a27d97d17606122f1d043732951b5ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list