[node-patches] Change in ovirt-node[master]: add efi partition to software based iscsi installs in efi mo...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: add efi partition to software based iscsi installs in efi mode
......................................................................


Patch Set 2: (3 inline comments)

....................................................
Commit Message
Line 10: the other partition sizes of 256MB and allows for the creation
Line 11: of an efi partition if booted in efi mode. Patch completes 99%
Line 12: of the iscsi root installation on efi. The efi bootloader entry
Line 13: in this scenario still has reliability issues and will be fixed
Line 14: in a followup patch.
The description is fine for me, but could you add a description - here or somewhere else - how the whole software iscsi boot is intended to work?
Line 15: 
Line 16: Change-Id: I7bb36a4a3b13f13a23a8e72f3e3028f2f5738cfd


....................................................
File scripts/ovirt-init-functions.sh
Line 389
Line 390
Line 391
Line 392
Line 393
The iscsi_install flag is not set in the default/ovirt file anymore?


....................................................
File scripts/ovirtnode/storage.py
Line 834:                          self.LABEL_TYPE + "\"")
Line 835:             _functions.passthrough(parted_cmd, logger.debug)
Line 836:             logger.debug("Creating Root and RootBackup Partitions")
Line 837:             if _functions.is_efi_boot():
Line 838:                 self.create_efi_partition()
why is create_efi_partition called twice?
Line 839:             else:
Line 840:                 # create partition labeled bios_grub
Line 841:                 parted_cmd = ("parted \"" + self.ROOTDRIVE +
Line 842:                              "\" -s \"mkpart primary 1M " +


--
To view, visit http://gerrit.ovirt.org/12253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb36a4a3b13f13a23a8e72f3e3028f2f5738cfd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>