[node-patches] Change in ovirt-node[master]: system: No version failure when not installed

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Feb 27 09:30:28 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: system: No version failure when not installed
......................................................................

system: No version failure when not installed

Previously the retrieval of version informations about an (probably)
existing Node installation failed in the case when no Node was
installed.
Now the output is handled correctly.

Change-Id: I362a648b3766b5bd37e9fac404dece915084bf4f
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/tui/src/ovirt/node/utils/system.py
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/77/12477/1

diff --git a/scripts/tui/src/ovirt/node/utils/system.py b/scripts/tui/src/ovirt/node/utils/system.py
index 5e2ad7c..b8782c6 100644
--- a/scripts/tui/src/ovirt/node/utils/system.py
+++ b/scripts/tui/src/ovirt/node/utils/system.py
@@ -93,8 +93,8 @@
     """Informations about the installation media - where the current
     installation is run from
     """
-    version = None
-    release = None
+    version = "0"
+    release = "0"
 
     @property
     def full_version(self):
@@ -114,7 +114,9 @@
 
     def load(self):
         from ovirtnode.ovirtfunctions import get_media_version_number
-        self.version, self.release = get_media_version_number()
+        data = get_media_version_number()
+        if data:
+            self.version, self.release = data
 
     def __str__(self):
         return self.full_version
@@ -157,7 +159,9 @@
 
     def load(self):
         from ovirtnode.ovirtfunctions import get_installed_version_number
-        self.version, self.release = get_installed_version_number()
+        data = get_installed_version_number()
+        if data:
+            self.version, self.release = data
 
 
 class Keyboard(base.Base):


--
To view, visit http://gerrit.ovirt.org/12477
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I362a648b3766b5bd37e9fac404dece915084bf4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list