[node-patches] Change in ovirt-node[master]: kdump: Add console based transaction progress

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: kdump: Add console based transaction progress
......................................................................

kdump: Add console based transaction progress

A console (non-TUI) based transaction visualization is used for KDump
because user input is required (for ssh-copy-id).

Change-Id: Ieade379ea04c841b784b9c64f23a4948ca46d7e6
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/tui/src/ovirt/node/setup/kdump_page.py
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/35/10635/1

diff --git a/scripts/tui/src/ovirt/node/setup/kdump_page.py b/scripts/tui/src/ovirt/node/setup/kdump_page.py
index 83d99fd..a795796 100644
--- a/scripts/tui/src/ovirt/node/setup/kdump_page.py
+++ b/scripts/tui/src/ovirt/node/setup/kdump_page.py
@@ -25,6 +25,7 @@
 from ovirt.node import utils, plugins, ui, valid
 from ovirt.node.config import defaults
 from ovirt.node.plugins import Changeset
+from ovirt.node.utils import console
 
 
 class Plugin(plugins.NodePlugin):
@@ -70,8 +71,8 @@
         # FIXME improve validation for ssh and nfs
         return {
                 "kdump.type": valid.Options(dict(self._types).keys()),
-                "kdump.ssh_location": valid.NoSpaces(),
-                "kdump.nfs_location": valid.NoSpaces(),
+                "kdump.ssh_location": valid.Empty() | valid.NoSpaces(),
+                "kdump.nfs_location": valid.Empty() | valid.NoSpaces(),
             }
 
     def ui_content(self):
@@ -140,5 +141,8 @@
                 model.update(None, None, None)
             txs += model.transaction()
 
-        progress_dialog = ui.TransactionProgressDialog(txs, self)
-        progress_dialog.run()
+        with self.application.ui.suspended():
+            progress_dialog = console.TransactionProgress(txs, self)
+            progress_dialog.run()
+            console.writeln("\nPlease press any key to continue")
+            console.wait_for_keypress()


--
To view, visit http://gerrit.ovirt.org/10635
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieade379ea04c841b784b9c64f23a4948ca46d7e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>