[node-patches] Change in ovirt-node[master]: install: Fix erasure and discovery of disk labels

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: install: Fix erasure and discovery of disk labels
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File scripts/ovirtnode/ovirtfunctions.py
Line 1107:     ## zero out the GPT secondary header
Line 1108:     #logger.info("Wiping secondary gpt header")
Line 1109:     #disk_kb = subprocess_closefds("sfdisk -s \""+ drive +"\" 2>/dev/null", shell=True, stdout=PIPE, stderr=STDOUT)
Line 1110:     #disk_kb_count = disk_kb.stdout.read()
Line 1111:     #system_closefds("dd if=/dev/zero of=\"" +drive +"\" bs=1024 seek=$(("+ disk_kb_count+" - 1)) count=1 &>>" + OVIRT_TMP_LOGFILE)
commented sections left in for any particular reason?
Line 1112:     system_closefds("sync")
Line 1113: 
Line 1114: def test_ntp_configuration(self):
Line 1115:     # stop ntpd service for testing


--
To view, visit http://gerrit.ovirt.org/10288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147a9aef04633332b3503cfeec0e738b81c824de
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>