[node-patches] Change in ovirt-node[master]: check for sblim-sfcb package before adding cim account rhbz#...

mburns at redhat.com mburns at redhat.com
Wed Jan 16 11:35:44 UTC 2013


Michael Burns has posted comments on this change.

Change subject: check for sblim-sfcb package before adding cim account rhbz#894070
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File recipe/common-post.ks
Line 248: if rpm -q sblim-sfcb
Line 249: then
Line 250: groupadd cim
Line 251: useradd -g cim -G sfcb -s /sbin/nologin cim
Line 252: fi
this should move to the cim plugin configuration.  As it stands with this change, the code will not ever be executed since cim is only installed in the plugin and not in the base image.
Line 253: 
Line 254: # disable yum repos by default
Line 255: augtool << \EOF_yum
Line 256: set /files/etc/yum.repos.d/fedora.repo/fedora/enabled 0


--
To view, visit http://gerrit.ovirt.org/11072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd9f59d653a075a668ee82b0d7862a5e4b25876
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list