[node-patches] Change in ovirt-node[master]: installer: Fix other-disk disk selection

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Fix other-disk disk selection
......................................................................

installer: Fix other-disk disk selection

Previously the installer tried to populate the disk details widget on
the root device page even when "Other Device" was selected. This failed
and raised an exception.
With this patch the installer only shows details when the device is show
in the list and not the "other device" entry.

rhbz#895413

Change-Id: I072638aea4ed2394b9c0e1529a04743a94a9250d
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/ovirt-config-installer.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/39/11239/1

diff --git a/scripts/ovirt-config-installer.py b/scripts/ovirt-config-installer.py
index 8419224..027a645 100644
--- a/scripts/ovirt-config-installer.py
+++ b/scripts/ovirt-config-installer.py
@@ -532,7 +532,11 @@
                 self.hostvg_checkbox.setEntryValue("OtherDevice", selected = 0)
             if self.hostvg_checkbox.getEntryValue("OtherDevice")[1] == 1 and dev == "OtherDevice":
                 for d in self.dev_names:
-                    if not d == self.live_disk:
+                    if d != self.live_disk and d in self.disk_dict:
+                        # only disks from disk_dict and if it's not the live
+                        # media
+                        # self.hostvg_checkbox is populated w entries from
+                        # self.disk_dict
                         d = translate_multipath_device(d)
                         self.hostvg_checkbox.setEntryValue(d, selected = 0)
         if "Location" in dev or "NoDevices" in dev or "OtherDevice" in dev:


--
To view, visit http://gerrit.ovirt.org/11239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I072638aea4ed2394b9c0e1529a04743a94a9250d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>